Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers
From: Borislav Petkov
Date: Thu Jun 02 2016 - 02:57:35 EST
On Wed, Jun 01, 2016 at 05:11:57PM -0700, Dave Hansen wrote:
> +#define INTEL_FAM6_MODEL_CORE_YONAH 0x0E
> +#define INTEL_FAM6_MODEL_CORE2_MEROM 0x0F
That "MODEL_" part looks redundant too IMO - you could simply do
INTEL_FAM6_NEHALEM and
INTEL_FAM6_SKYLAKE_DESKTOP
...
and so on and it is still clear what it is.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.