Re: [PATCH 01/20] x86, intel: Introduce macros for Intel family numbers

From: Rafael J. Wysocki
Date: Thu Jun 02 2016 - 17:45:20 EST


On Thursday, June 02, 2016 08:57:15 AM Borislav Petkov wrote:
> On Wed, Jun 01, 2016 at 05:11:57PM -0700, Dave Hansen wrote:
> > +#define INTEL_FAM6_MODEL_CORE_YONAH 0x0E
> > +#define INTEL_FAM6_MODEL_CORE2_MEROM 0x0F
>
> That "MODEL_" part looks redundant too IMO - you could simply do
>
> INTEL_FAM6_NEHALEM and
> INTEL_FAM6_SKYLAKE_DESKTOP
> ...
>
> and so on and it is still clear what it is.

I'm with you on that, but that's rather minor and the changes in this series
are generally fine by me, so Dave please feel free to add

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

to all of it.

Thanks,
Rafael