Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block
From: Will Deacon
Date: Fri Jun 03 2016 - 05:49:58 EST
On Fri, Jun 03, 2016 at 10:45:20AM +0100, Will Deacon wrote:
> On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote:
> > On 2016/6/2 4:13, Rob Herring wrote:
> > > I believe you still need this and not the one above. You only need it
> > > within the loop if you return. Otherwise, the last node always need to
> > > be put.
> >
> > OK. Thanks.
> >
> > Addition with Matthias's suggestion, I will move "return" into this patch,
> > so that this of_node_put(np) can be safely removed.
>
> Do you want to include Kefeng's [1] patches in your series too? We don't
> need two sets of related NUMA cleanups :)
Actually, I see you've already respun the series, do don't worry about
doing another version just for this.
Will