Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block

From: Leizhen (ThunderTown)
Date: Sun Jun 05 2016 - 21:25:47 EST




On 2016/6/3 17:45, Will Deacon wrote:
> On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote:
>> On 2016/6/2 4:13, Rob Herring wrote:
>>> I believe you still need this and not the one above. You only need it
>>> within the loop if you return. Otherwise, the last node always need to
>>> be put.
>>
>> OK. Thanks.
>>
>> Addition with Matthias's suggestion, I will move "return" into this patch,
>> so that this of_node_put(np) can be safely removed.
>
> Do you want to include Kefeng's [1] patches in your series too? We don't
> need two sets of related NUMA cleanups :)

Yes, It's originally suggested by Joe Perches.

>
> Will
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/432715.html
>
> .
>