Re: [PATCH perf/core v10 07/23] perf probe: Add --cache option to cache the probe definitions

[Masami Hiramatsu]

On Thu, 9 Jun 2016 11:18:50 -0300
Arnaldo Carvalho de Melo <acme@xxxxxxxxxx> wrote:

> Em Wed, Jun 08, 2016 at 06:30:10PM +0900, Masami Hiramatsu escreveu:
> > @@ -2555,6 +2556,14 @@ static int __add_probe_trace_events(struct perf_probe_event *pev,
> >  	}
> >  	if (ret == -EINVAL && pev->uprobes)
> >  		warn_uprobe_event_compat(tev);
> > +	if (ret == 0 && probe_conf.cache) {
> > +		cache = probe_cache__new(pev->target);
> > +		if (cache) {
> > +			probe_cache__add_entry(cache, pev, tevs, ntevs);
> > +			probe_cache__commit(cache);
> 
> These two functions may fail, please check its return and forward errors
> appropriately.

OK, will check and warn that.

Thank you!
-- 
Masami Hiramatsu <mhiramat@xxxxxxxxxx>