Re: [TEST PATCH] rtc: convert ds1307 to interim probe_new

From: kbuild test robot
Date: Sun Jun 12 2016 - 17:28:24 EST


Hi,

[auto build test ERROR on abelloni/rtc-next]
[also build test ERROR on v4.7-rc3 next-20160609]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Kieran-Bingham/rtc-convert-ds1307-to-interim-probe_new/20160613-051618
base: https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git rtc-next
config: sparc64-allmodconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 5.3.1-8) 5.3.1 20160205
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=sparc64

All error/warnings (new ones prefixed by >>):

drivers/rtc/rtc-ds1307.c: In function 'ds1307_probe':
>> drivers/rtc/rtc-ds1307.c:1262:9: error: implicit declaration of function 'i2c_of_match_device' [-Werror=implicit-function-declaration]
idof = i2c_of_match_device(ds1307_dt_ids, client);
^
>> drivers/rtc/rtc-ds1307.c:1262:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
idof = i2c_of_match_device(ds1307_dt_ids, client);
^
>> drivers/rtc/rtc-ds1307.c:1269:16: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
chip = &chips[(int)idof->data];
^
drivers/rtc/rtc-ds1307.c:1274:17: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
ds1307->type = (int) idof->data;
^
drivers/rtc/rtc-ds1307.c: At top level:
>> drivers/rtc/rtc-ds1307.c:1634:2: error: unknown field 'probe_new' specified in initializer
.probe_new = ds1307_probe,
^
>> drivers/rtc/rtc-ds1307.c:1634:15: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types]
.probe_new = ds1307_probe,
^
drivers/rtc/rtc-ds1307.c:1634:15: note: (near initialization for 'ds1307_driver.id_table')
cc1: some warnings being treated as errors

vim +/i2c_of_match_device +1262 drivers/rtc/rtc-ds1307.c

1256
1257 ds1307 = devm_kzalloc(&client->dev, sizeof(struct ds1307), GFP_KERNEL);
1258 if (!ds1307)
1259 return -ENOMEM;
1260
1261 /* If we've got this far, this shouldn't be able to fail - but check anyway for now */
> 1262 idof = i2c_of_match_device(ds1307_dt_ids, client);
1263 if (!idof) {
1264 dev_err(&client->dev, "Probe failed to find an id entry\n");
1265 return -ENODEV;
1266 }
1267
1268 /* Now we can set our chip entry */
> 1269 chip = &chips[(int)idof->data];
1270
1271 i2c_set_clientdata(client, ds1307);
1272
1273 ds1307->client = client;
> 1274 ds1307->type = (int) idof->data;
1275
1276 if (!pdata && client->dev.of_node)
1277 ds1307_trickle_of_init(client, chip);

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

Attachment: .config.gz
Description: Binary data