Re: [PATCH net-next] net: ena: Add a driver for Amazon Elastic Network Adapters (ENA)

[Francois Romieu]

Netanel Belgazal <netanel@xxxxxxxxxxxxxxxxx> :
[...]
> > diff --git a/drivers/net/ethernet/amazon/ena/ena_com.h b/drivers/net/ethernet/amazon/ena/ena_com.h
> > new file mode 100644
> > index 0000000..e49ba43
> > --- /dev/null
> > [...]
> > +static inline void ena_com_update_intr_reg(struct ena_eth_io_intr_reg *intr_reg,
> > +					   u32 rx_delay_interval,
> > +					   u32 tx_delay_interval,
> > +					   bool unmask)
> > +{
> > +	intr_reg->intr_control = 0;
> > +	intr_reg->intr_control |= rx_delay_interval &
> > +		ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK;
> > +
> > +	intr_reg->intr_control |=
> > +		(tx_delay_interval << ENA_ETH_IO_INTR_REG_TX_INTR_DELAY_SHIFT)
> > +		& ENA_ETH_IO_INTR_REG_RX_INTR_DELAY_MASK;
> >                                       ^^ TX ?
> >
> > Extra: you should not return NETDEV_TX_BUSY in the xmit handler while
> > queueing is still enabled. Please drop packet and return NETDEV_TX_OK.
> Ack.
> 
> Thanks for your review.

Ack/nack regarding use of ..._RX_INTR_DELAY_MASK with ..._TX_INTR_DELAY_SHIFT ?

-- 
Ueimor