Re: linux-next: build warnings after merge of the pci tree

From: Bjorn Helgaas
Date: Mon Jun 20 2016 - 21:32:51 EST


On Mon, Jun 20, 2016 at 8:08 PM, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote:
> Hi Bjorn,
>
> On Mon, 20 Jun 2016 14:11:36 -0500 Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote:
>>
>> On Mon, Jun 20, 2016 at 11:52:13AM +1000, Stephen Rothwell wrote:
>> > Hi Bjorn,
>> >
>> > After merging the pci tree, today's linux-next build (arm
>> > multi_v7_defconfig) produced these warnings:
>> >
>> > drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
>> > drivers/pci/host/pci-host-common.c:88:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> > return err;
>> > ^
>> > drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> > return PTR_ERR(cfg);
>> > ^
>> > drivers/pci/host/pci-host-common.c:108:9: warning: return makes pointer from integer without a cast [-Wint-conversion]
>> > return err;
>> > ^
>> >
>> > Introduced by commit
>> >
>> > 3f8dcfc3fbba ("PCI: generic: Free resource list close to where it's allocated")
>>
>> Fixed, thanks a lot, Stephen!
>
> Thanks. Unfortunately, I still get this warning:
>
> drivers/pci/host/pci-host-common.c: In function 'gen_pci_init':
> drivers/pci/host/pci-host-common.c:93:10: warning: return makes pointer from integer without a cast [-Wint-conversion]
> return PTR_ERR(cfg);
> ^

Crap, sorry, PTR_ERR/ERR_PTR confusion. I *think* I fixed it now.

Bjorn