Re: [PATCH 2/2] pinctrl: as3722: convert PINCTRL_AS3722 from bool to tristate

From: Linus Walleij
Date: Wed Jun 22 2016 - 12:09:56 EST


On Mon, Jun 13, 2016 at 11:10 PM, Paul Gortmaker
<paul.gortmaker@xxxxxxxxxxxxx> wrote:

> The Kconfig currently controlling compilation of this code is:
>
> config PINCTRL_AS3722
> bool "Pinctrl and GPIO driver for ams AS3722 PMIC"
>
> ...meaning that it currently is not being built as a module by anyone.
>
> During an audit for non-modular drivers using modular infrastructure
> this driver showed up.
>
> But rather than demodularize it, Laxman indicated that it would be
> prefereable to instead convert the driver option to tristate.
>
> This does that, and confirms that it will compile and modpost as
> such. However, since I do not have the hardware to confirm that
> no new runtime issues exist when modular, that remains untested.
>
> Cc: Laxman Dewangan <ldewangan@xxxxxxxxxx>
> Cc: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Cc: linux-gpio@xxxxxxxxxxxxxxx
> Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>

Patch applied.

Yours,
Linus Walleij