Re: [PATCH V3 2/4] clk: Combine DT binding doc for max77686 and max77802

[Laxman Dewangan]

Hi Rob,

On Tuesday 21 June 2016 12:16 PM, Laxman Dewangan wrote:
> On Monday 20 June 2016 10:09 PM, Rob Herring wrote:
> > On Fri, Jun 17, 2016 at 04:21:05PM +0530, Laxman Dewangan wrote:
> > > diff --git 
> > > a/Documentation/devicetree/bindings/clock/maxim,max77686.txt 
> > > b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
> > > index 9c40739..4d973b5 100644
> > > --- a/Documentation/devicetree/bindings/clock/maxim,max77686.txt
> > > +++ b/Documentation/devicetree/bindings/clock/maxim,max77686.txt
> > > @@ -1,11 +1,15 @@
> > > -Binding for Maxim MAX77686 32k clock generator block
> > > +Binding for Maxim MAX77686/MAX77802 32k clock generator block
> > >   -This is a part of device tree bindings of MAX77686 multi-function 
> > > device.
> > > -More information can be found in bindings/mfd/max77686.txt file.
> > > +This is a part of device tree bindings of MAX77686/MAX77802 
> > > multi-function
> > > +device. More information can be found in bindings/mfd/max77686.txt 
> > > file for
> > > +MAX77686 and bindings/mfd/max77802.txt for MAX77802.
> > >     The MAX77686 contains three 32.768khz clock outputs that can be 
> > > controlled
> > >   (gated/ungated) over I2C.
> > >   +The MAX77802 contains two 32.768khz clock outputs that can be 
> > > controlled
> > > +(gated/ungated) over I2C.
> > > +
> > >   Following properties should be presend in main device node of the 
> > > MFD chip.
> > >     Required properties:
> > I'd expect to see compatible strings updated...
>
> There is no separate compatible string for clock. The clock nodes is 
> the parent node only and the compatible described in the parent DT 
> binding doc.
>
>
> Do we also need to add same thing here?

Are you fine with the above? As there is no compatible string for clock 
(clock does not have separate node), do I still need to add explicitly here?