Re: [PATCH v2 5/5] regulator: tps65218: do not disable DCDC3 during poweroff on broken PMICs

From: Lee Jones
Date: Tue Jun 28 2016 - 07:45:05 EST


On Tue, 28 Jun 2016, Keerthy wrote:

>
>
> On Tuesday 28 June 2016 04:43 PM, Lee Jones wrote:
> > On Tue, 28 Jun 2016, Lee Jones wrote:
> >
> > > On Mon, 27 Jun 2016, Mark Brown wrote:
> > >
> > > > On Fri, Jun 24, 2016 at 01:58:11PM +0530, Keerthy wrote:
> > > > > From: Tero Kristo <t-kristo@xxxxxx>
> > > > >
> > > > > Some versions of tps65218 do not seem to support poweroff modes properly
> > > > > if DCDC3 regulator is shut-down. Thus, keep it enabled even during
> > > > > poweroff if the version info matches the broken silicon revision.
> > > >
> > > > This is fine but depends on the MFD bit so needs to wait for that to be
> > > > reviewed.
> > >
> > > I think it's fine for you to take this.
> >
> > Tell a lie. I just saw the struct member added in the other patch.
>
> Oh yes! I will wait for this series to get in completely. I guess more
> re-basing would be needed on the other patch.

Not if they all go in via Mark's tree.

> > Do you want to take the set? If so, I'll just Ack my bit.
> >
> > For the MFD changes in this patch:
> > Acked-by: Lee Jones <lee.jones@xxxxxxxxxx>
> >

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org â Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog