Re: [PATCH] w1: Remove unneeded header file

From: Julia Lawall
Date: Tue Jun 28 2016 - 09:50:06 EST


On Tue, 28 Jun 2016, Evgeniy Polyakov wrote:

> Hi
>
> 24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@xxxxxxxxx>:
> > Drop redundant include of moduleparam.h
> >
> > The Coccinelle semantic patch used to make this change is as follows:
> > @ includesmodule @
> > @@
> >
> > #include <linux/module.h>
> >
> > @ depends on includesmodule @
> > @@
> >
> > - #include <linux/moduleparam.h>
> >
> > Signed-off-by: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>
>
> Looks good to me, but these @@ are pretty cryptic.

There are two rules. The first checks for an include of module.h. The
second depends on the success of the first one. It removes and include o
moduleparam.h.

julia