Re: [PATCH] w1: Remove unneeded header file

From: Evgeniy Polyakov
Date: Tue Jun 28 2016 - 10:04:48 EST


Hi

28.06.2016, 16:50, "Julia Lawall" <julia.lawall@xxxxxxx>:
>> Â24.06.2016, 09:18, "Amitoj Kaur Chawla" <amitoj1606@xxxxxxxxx>:
>> Â> The Coccinelle semantic patch used to make this change is as follows:
>> Â> @ includesmodule @
>> Â> @@
>> Â>
>> Â> #include <linux/module.h>
>> Â>
>> Â> @ depends on includesmodule @
>> Â> @@
>> Â>
>> Â> - #include <linux/moduleparam.h>
>> Â>
>> Â> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@xxxxxxxxx>
>>
>> ÂLooks good to me, but these @@ are pretty cryptic.
>
> There are two rules. The first checks for an include of module.h. The
> second depends on the success of the first one. It removes and include o
> moduleparam.h.

Ok, I see, it makes much more sense now :)

Thank you for clarification