Re: [PATCH v4 12/22] sh: Add PCI host bridge driver for SH7751

[Arnd Bergmann]

On Wednesday, June 29, 2016 10:40:57 PM CEST Yoshinori Sato wrote:
> +               interrupt-map = <0x0000 0 1 &cpldintc 0 0>,
> +                                0x0800 0 1 &cpldintc 1 0>,
> +                                0x1000 0 1 &cpldintc 2 0>,
> +                                0x1800 0 1 &cpldintc 3 0>,
> +                                0x1800 0 2 &cpldintc 0 0>;

I just noticed the typo: you have more closing '>' than opening '<'
here, so this is not valid syntax.

> +
> +static __refdata struct platform_driver sh7751_pci_driver = {
> +       .driver = {
> +               .name = "sh7751-pci",
> +               .of_match_table = sh7751_pci_of_match,
> +       },
> +       .probe = sh7751_pci_probe,
> +};
> +builtin_platform_driver(sh7751_pci_driver);

I think you need to add '.suppress_bind_attrs = true' to prevent
the device to be unbound and rebound through sysfs, otherwise
the __init annotation on the probe function is wrong.

Everything else looks fine to me now.

	Arnd