Re: [PATCH net-next 06/24] rxrpc: Dup the main conn list for the proc interface

From: David Miller
Date: Tue Jul 05 2016 - 13:17:52 EST


From: David Howells <dhowells@xxxxxxxxxx>
Date: Tue, 05 Jul 2016 14:12:54 +0100

> The main connection list is used for two independent purposes: primarily it
> is used to find connections to reap and secondarily it is used to list
> connections in procfs.
>
> Split the procfs list out from the reap list. This allows the reap list to
> be phased out in stages as the client conns and service conns acquire their
> own separate connection management strategies.
>
> Whilst we're at it, use the address information stored in conn->proto when
> displaying through procfs rather than accessing the peer record.
>
> Signed-off-by: David Howells <dhowells@xxxxxxxxxx>

Wouldn't it be better to just code the proc stuff to walk whatever
table the rest of the stack uses to hold all of the connections
as TCP et al. do?