Re: [PATCH 1/5] security, overlayfs: provide copy up security hook for unioned files
From: kbuild test robot
Date: Tue Jul 05 2016 - 13:22:06 EST
Hi,
[auto build test WARNING on miklos-vfs/overlayfs-next]
[also build test WARNING on v4.7-rc6 next-20160705]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Vivek-Goyal/Overlayfs-SELinux-Support/20160706-000037
base: https://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=m68k
All warnings (new ones prefixed by >>):
fs/overlayfs/copy_up.c: In function 'ovl_copy_up_locked':
>> fs/overlayfs/copy_up.c:262:8: warning: passing argument 2 of 'security_inode_copy_up' from incompatible pointer type
err = security_inode_copy_up(dentry, &old_creds);
^
In file included from fs/overlayfs/copy_up.c:16:0:
include/linux/security.h:762:19: note: expected 'struct dentry *' but argument is of type 'const struct cred **'
static inline int security_inode_copy_up(struct dentry *src, struct dentry *dst)
^
vim +/security_inode_copy_up +262 fs/overlayfs/copy_up.c
246 struct dentry *upper = NULL;
247 umode_t mode = stat->mode;
248 int err;
249 const struct cred *old_creds = NULL;
250
251 newdentry = ovl_lookup_temp(workdir, dentry);
252 err = PTR_ERR(newdentry);
253 if (IS_ERR(newdentry))
254 goto out;
255
256 upper = lookup_one_len(dentry->d_name.name, upperdir,
257 dentry->d_name.len);
258 err = PTR_ERR(upper);
259 if (IS_ERR(upper))
260 goto out1;
261
> 262 err = security_inode_copy_up(dentry, &old_creds);
263 if (err < 0)
264 goto out2;
265
266 /* Can't properly set mode on creation because of the umask */
267 stat->mode &= S_IFMT;
268 err = ovl_create_real(wdir, newdentry, stat, link, NULL, true);
269 stat->mode = mode;
270 if (old_creds)
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Attachment:
.config.gz
Description: Binary data