Re: [PATCH] iommu/iova: validate iova_domain input to put_iova_domain
From: Joerg Roedel
Date: Thu Jul 14 2016 - 04:34:32 EST
On Wed, Jul 13, 2016 at 02:49:32PM -0400, Nate Watterson wrote:
> Passing a NULL or uninitialized iova_domain into put_iova_domain
> will currently crash the kernel when the unconfigured iova_domain
> data members are accessed. To prevent this from occurring, this patch
> adds a check to make sure that the domain is non-NULL and that the
> domain granule is non-zero. The granule can be used to check if the
> domain was properly initialized because calling init_iova_domain
> with a granule of zero would have already triggered a BUG statement
> crashing the kernel.
Have you seen real crashes happening because of this?
Joerg