Re: [PATCH 07/12] syscon: dt-bindings: Add documentation for Aspeed system control units

[Rob Herring]

On Wed, Jul 20, 2016 at 03:28:28PM +0930, Andrew Jeffery wrote:
> Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> ---
>  Documentation/devicetree/bindings/mfd/aspeed-scu.txt | 16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> new file mode 100644
> index 000000000000..4df798799101
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> @@ -0,0 +1,16 @@
> +The Aspeed System Control Unit manages the global behaviour of the SoC,
> +configuring elements such as clocks, pinmux, and reset.
> +
> +Required properties:
> +- compatible:	One of:
> +		"aspeed,g4-scu", "syscon", "simple-mfd"
> +		"aspeed,g5-scu", "syscon", "simple-mfd"

These (and the pinctrl probably) really need SoC specific compatible 
strings. You can keep these as fallbacks though. These are the parts of 
SoCs that really vary chip to chip.

Rob