Re: [PATCH 07/12] syscon: dt-bindings: Add documentation for Aspeed system control units
From: Andrew Jeffery
Date: Wed Jul 20 2016 - 21:11:50 EST
On Wed, 2016-07-20 at 14:09 -0500, Rob Herring wrote:
> On Wed, Jul 20, 2016 at 03:28:28PM +0930, Andrew Jeffery wrote:
> >
> > Signed-off-by: Andrew Jeffery <andrew@xxxxxxxx>
> > ---
> > ÂDocumentation/devicetree/bindings/mfd/aspeed-scu.txt | 16 ++++++++++++++++
> > Â1 file changed, 16 insertions(+)
> > Âcreate mode 100644 Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/aspeed-scu.txt b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> > new file mode 100644
> > index 000000000000..4df798799101
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/aspeed-scu.txt
> > @@ -0,0 +1,16 @@
> > +The Aspeed System Control Unit manages the global behaviour of the SoC,
> > +configuring elements such as clocks, pinmux, and reset.
> > +
> > +Required properties:
> > +- compatible: One of:
> > + "aspeed,g4-scu", "syscon", "simple-mfd"
> > + "aspeed,g5-scu", "syscon", "simple-mfd"
> These (and the pinctrl probably) really need SoC specific compatibleÂ
> strings. You can keep these as fallbacks though. These are the parts ofÂ
> SoCs that really vary chip to chip.
I'll add the SoC-specific compatible strings.
Cheers,
AndrewAttachment:
signature.asc
Description: This is a digitally signed message part