Re: staging: ks7010: Rename jump labels

[SF Markus Elfring]

>> Would you like to support the renaming of a label like "error_out1"
>> (in the function "ks7010_upload_firmware" for example)?
> 
> They should be renamed too. Anything using numbers instead of explicit

Interesting …


> Anything using numbers instead of explicit labels should be updated.

Would you dare to search for corresponding update candidates explicitly
by special semantic patch scripts?


> I included the reasons in the patch I just sent,
> hopefully the documentation is clearer now.

I am curious on how feedback will evolve for your suggestion
"CodingStyle: Clarify and complete chapter 7".
https://lkml.org/lkml/2016/7/25/207

How do you think about to show a shorter label like "free_bar"
(instead of "err_free_bar") as an example?


>> "Source code review around jump label usage"?
>> https://lkml.org/lkml/2015/12/11/378
>> http://article.gmane.org/gmane.linux.kernel/2106190
> 
> Personally I see no value in such statistics.

Do they indicate any code smells eventually?


> Either labels are wrong (either wrong indentation or wrong name)
> and should be fixed, or they are correct and you should not touch them.

Do you find such changes worthwhile (without touching also any surrounding
source code)?

Regards,
Markus