RE: [PATCH 4.6 143/203] memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing
From: SebastienOcquidant
Date: Tue Jul 26 2016 - 02:25:14 EST
ï
-----------------------------
Eaton Industries (France) S.A.S ~ SiÃge social: 110 Rue Blaise Pascal, Immeuble Le VisÃo - BÃtiment A InnovallÃe, 38330, Montbonnot-St.-Martin, France ~ Lieu d'enregistrement au registre du commerce: Grenoble ~ NumÃro d'enregistrement: 509 653 176 ~ Capital social souscrit et liberÃ:â 16215441 ~ NumÃro de TVA: FR47509653176
à
-----------------------------
-----Message d'origine-----
DeÂ: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx]
EnvoyÃÂ: lundi 25 juillet 2016 22:56
ÃÂ: linux-kernel@xxxxxxxxxxxxxxx
CcÂ: Greg Kroah-Hartman; stable@xxxxxxxxxxxxxxx; Ocquidant, Sebastien; Roger Quadros
ObjetÂ: [PATCH 4.6 143/203] memory: omap-gpmc: Fix omap gpmc EXTRADELAY timing
4.6-stable review patch. If anyone has any objections, please let me know.
------------------
From: Ocquidant, Sebastien <sebastienocquidant@xxxxxxxxx>
commit 8f50b8e57442d28e41bb736c173d8a2490549a82 upstream.
In the omap gpmc driver it can be noticed that GPMC_CONFIG4_OEEXTRADELAY is overwritten by the WEEXTRADELAY value from the device tree and GPMC_CONFIG4_WEEXTRADELAY is not updated by the value from the device tree.
As a consequence, the memory accesses cannot be configured properly when the extra delay are needed for OE and WE.
Fix the update of GPMC_CONFIG4_WEEXTRADELAY with the value from the device tree file and prevents GPMC_CONFIG4_OEXTRADELAY being overwritten by the WEXTRADELAY value from the device tree.
Signed-off-by: Ocquidant, Sebastien <sebastienocquidant@xxxxxxxxx>
Signed-off-by: Roger Quadros <rogerq@xxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
drivers/memory/omap-gpmc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/memory/omap-gpmc.c
+++ b/drivers/memory/omap-gpmc.c
@@ -394,7 +394,7 @@ static void gpmc_cs_bool_timings(int cs,
gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG4,
GPMC_CONFIG4_OEEXTRADELAY, p->oe_extra_delay);
gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG4,
- GPMC_CONFIG4_OEEXTRADELAY, p->we_extra_delay);
+ GPMC_CONFIG4_WEEXTRADELAY, p->we_extra_delay);
gpmc_cs_modify_reg(cs, GPMC_CS_CONFIG6,
GPMC_CONFIG6_CYCLE2CYCLESAMECSEN,
p->cycle2cyclesamecsen);
========================================================================================
Hi Greg,
OK for me
SÃbastien Ocquidant