Re: staging: wilc1000: Reduce scope for a few variables in mac_ioctl()

From: SF Markus Elfring
Date: Tue Jul 26 2016 - 02:26:29 EST


>> - if (strncasecmp(buff, "RSSI", length) == 0) {
>> + if (strncasecmp(buff, "RSSI", 0) == 0) {
>> + s8 rssi;
>> +
>
> Um, please think a second about if it makes any sense at all to compare
> zero chars of two strings.

Under which circumstances should the variable "length" contain an other
value than zero?

How can this open issue be fixed better?

Regards,
Markus