Re: [PATCH net-next 3/2] e1000e: convert systim overflow check to use flags2

[Jeff Kirsher]

On Tue, 2016-07-26 at 13:39 -0400, Jarod Wilson wrote:
> Per Jesse Brandeburg, e1000e should be using flags for this sort of
> thing.
> 
> Littering functional code with device-specific checks is much messier
> than
> simply checking a flag, and having device-specific init set flags as
> needed.
> There are probably a number of other cases in the e1000e code that
> could/should be converted similarly.
> 
> At present, this patch is a follow-up to the previously submitted 2
> patches, but I can redo the series to omit the conversion to a switch
> entirely, if so desired.
> 
> Suggested-by: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
> CC: Jesse Brandeburg <jesse.brandeburg@xxxxxxxxx>
> CC: Jeff Kirsher <jeffrey.t.kirsher@xxxxxxxxx>
> CC: intel-wired-lan@xxxxxxxxxxxxxxxx
> CC: netdev@xxxxxxxxxxxxxxx
> Signed-off-by: Jarod Wilson <jarod@xxxxxxxxxx>
> ---
> Âdrivers/net/ethernet/intel/e1000e/82571.cÂÂ |Â 6 ++++--
> Âdrivers/net/ethernet/intel/e1000e/e1000.hÂÂ |Â 1 +
> Âdrivers/net/ethernet/intel/e1000e/ich8lan.c |Â 3 ++-
> Âdrivers/net/ethernet/intel/e1000e/netdev.c | 10 ++--------
> Â4 files changed, 9 insertions(+), 11 deletions(-)

This generates a compile issue, so I will be dropping this patch and will
await an update.

Attachment: signature.asc
Description: This is a digitally signed message part