Re: [GIT PULL] f2fs for 4.8

From: Jens Axboe
Date: Wed Jul 27 2016 - 14:48:11 EST

On 07/27/2016 12:46 PM, Linus Torvalds wrote:
On Wed, Jul 27, 2016 at 11:29 AM, Jens Axboe <axboe@xxxxxx> wrote:

Looks OK to me, though I think you could have dropped the ->bi_rw
assignment in f2fs_submit_page_bio():

bio->bi_rw = fio->op_flags;
bio_set_op_attrs(bio, fio->op, fio->op_flags);

__submit_bio(fio->sbi, bio, fio->type);

Ahh, yes. I'll add a patch to drop that line, unless you just want to
do it yourself (or Jaegeuk Kim wants to do it in the f2fs tree).

I've got a few more things coming in this merge window, so I can just queue that up.

Jaegeuk, I'd still really want confirmation that it all actually
works. The extra line should be harmless, even if Jens is right that
it is ugly and wrong. It might be worth testing with that line

Yes please, I don't have an easy way to test it either.

Jens Axboe