Re: [GIT PULL] f2fs for 4.8

[Jaegeuk Kim]

On Wed, Jul 27, 2016 at 11:46:11AM -0700, Linus Torvalds wrote:
> On Wed, Jul 27, 2016 at 11:29 AM, Jens Axboe <axboe@xxxxxx> wrote:
> >
> > Looks OK to me, though I think you could have dropped the ->bi_rw
> > assignment in f2fs_submit_page_bio():
> >
> >         bio->bi_rw = fio->op_flags;
> >         bio_set_op_attrs(bio, fio->op, fio->op_flags);
> >
> >         __submit_bio(fio->sbi, bio, fio->type);
> 
> Ahh, yes. I'll add a patch to drop that line, unless you just want to
> do it yourself (or Jaegeuk Kim wants to do it in the f2fs tree).

Actually, I was writing an email to point that out. :)
Thanks to Jens for the patch for this.
Anyway, the changes look good to me as well.

> Jaegeuk, I'd still really want confirmation that it all actually
> works. The extra line should be harmless, even if Jens is right that
> it is ugly and wrong. It might be worth testing with that line
> removed.

I've confirmed that there is no problem; I've checked a round of xfstests and
fsstress test.

Thank you for resolving the conflicts.

Thanks,