Re: [PATCH v2] powerpc/32: fix csum_partial_copy_generic()

From: Segher Boessenkool
Date: Tue Aug 02 2016 - 09:32:27 EST


On Tue, Aug 02, 2016 at 10:07:05AM +0200, Christophe Leroy wrote:
> commit 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
> based on copy_tofrom_user()") introduced a bug when destination
> address is odd and initial csum is not null
>
> In that (rare) case the initial csum value has to be rotated one byte
> as well as the resulting value is
>
> This patch also fixes related comments
>
> Fixes: 7aef4136566b0 ("powerpc32: rewrite csum_partial_copy_generic()
> based on copy_tofrom_user()")
> Cc: stable@xxxxxxxxxxxxxxx
>
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>
> ---
> v2: updated comments as suggested by Segher

Thanks. It looks good to me now.


Segher