Re: [PATCH 1170/1285] Replace numeric parameter like 0444 with macro

[Takashi Sakamoto]

On Aug 2 2016 21:22, Baole Ni wrote:
> I find that the developers often just specified the numeric value
> when calling a macro which is defined with a parameter for access permission.
> As we know, these numeric value for access permission have had the corresponding macro,
> and that using macro can improve the robustness and readability of the code,
> thus, I suggest replacing the numeric parameter with the macro.
> 
> Signed-off-by: Chuansheng Liu <chuansheng.liu@xxxxxxxxx>
> Signed-off-by: Baole Ni <baolex.ni@xxxxxxxxx>

Reviewed-by: Takashi Sakamoto <o-takashi@xxxxxxxxxxxxx>

> ---
>  sound/firewire/fireworks/fireworks.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/sound/firewire/fireworks/fireworks.c b/sound/firewire/fireworks/fireworks.c
> index 71a0613..3390b4e 100644
> --- a/sound/firewire/fireworks/fireworks.c
> +++ b/sound/firewire/fireworks/fireworks.c
> @@ -27,16 +27,16 @@ static bool enable[SNDRV_CARDS]	= SNDRV_DEFAULT_ENABLE_PNP;
>  unsigned int snd_efw_resp_buf_size	= 1024;
>  bool snd_efw_resp_buf_debug		= false;
>  
> -module_param_array(index, int, NULL, 0444);
> +module_param_array(index, int, NULL, S_IRUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(index, "card index");
> -module_param_array(id, charp, NULL, 0444);
> +module_param_array(id, charp, NULL, S_IRUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(id, "ID string");
> -module_param_array(enable, bool, NULL, 0444);
> +module_param_array(enable, bool, NULL, S_IRUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(enable, "enable Fireworks sound card");
> -module_param_named(resp_buf_size, snd_efw_resp_buf_size, uint, 0444);
> +module_param_named(resp_buf_size, snd_efw_resp_buf_size, uint, S_IRUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(resp_buf_size,
>  		 "response buffer size (max 4096, default 1024)");
> -module_param_named(resp_buf_debug, snd_efw_resp_buf_debug, bool, 0444);
> +module_param_named(resp_buf_debug, snd_efw_resp_buf_debug, bool, S_IRUSR | S_IRGRP | S_IROTH);
>  MODULE_PARM_DESC(resp_buf_debug, "store all responses to buffer");
>  
>  static DEFINE_MUTEX(devices_mutex);
>