Re: [PATCH v3 1/4] mfd: mxs-lradc: Add support for mxs-lradc MFD

From: Ksenija StanojeviÄ
Date: Wed Aug 03 2016 - 16:21:00 EST


On Wed, Aug 3, 2016 at 9:57 PM, Marek Vasut <marex@xxxxxxx> wrote:
> On 08/03/2016 09:45 PM, Ksenija StanojeviÄ wrote:
>> On Wed, Aug 3, 2016 at 9:39 PM, Marek Vasut <marex@xxxxxxx> wrote:
>>> On 08/03/2016 09:34 PM, Ksenija StanojeviÄ wrote:
>>>> On Wed, Aug 3, 2016 at 9:13 PM, Marek Vasut <marex@xxxxxxx> wrote:
>>>>> On 08/03/2016 06:45 PM, Ksenija StanojeviÄ wrote:
>>>>>> Hi Fabio,
>>>>>
>>>>> Hi,
>>>>>
>>>>>> On Wed, Aug 3, 2016 at 6:35 PM, Fabio Estevam <festevam@xxxxxxxxx> wrote:
>>>>>>> Hi Ksenija,
>>>>>>>
>>>>>>> On Wed, Aug 3, 2016 at 1:32 PM, Ksenija StanojeviÄ
>>>>>>> <ksenija.stanojevic@xxxxxxxxx> wrote:
>>>>>>>
>>>>>>>> Can someone with imx23 board send me /proc/interrupts log, I
>>>>>>>> need irq numbers...
>>>>>>>
>>>>>>> Can't you get them from the MX23 Reference Manual (Table 5-1. i.MX23
>>>>>>> Interrupt Sources)?
>>>>>>
>>>>>> I thought it will be more reliable if I asked someone, since numbers from MX28
>>>>>> manual don't match with /proc/interrupts log.
>>>>>>
>>>>> What do you mean they don't match ? Please elaborate.
>>>>
>>>> irqs don't have the same values in Table 5.1 in MX28 manual and in
>>>> /proc/interrupts
>>>> output.
>>>>
>>>> For example:
>>>> touchscreen irq in MX28 manual have these values:
>>>> 10 (source number) and 0x0028 (vector number)
>>>>
>>>> in /proc/interrupts:
>>>> 210: 0 - 10 Edge mxs-lradc-touchscreen
>>>
>>> I see lradc_touch_irq in the MX28RM is IRQ 10 and it is also 10 in your
>>> /proc/interrupts output . What am I missing ?
>>
>> I was referring to the number of the first column 210, that's the number that
>> I need and cannot find in the Table of the manual.
>
> The first number in /proc/interrupts is the number which Linux maps to
> that particular IRQ line, but that number can be anything, it does not
> (need to) match the hardware in any way. What do you need it for ?

Thanks, I didn't know that. Well I was using the first number to map
irq names to irq number in DEFINE_RES_IRQ_NAMED.
Otherwise I get probe failure:
probe of mxs-lradc-ts failed with error -22

It's because platform_get_irq_byname cannot find irq for the given
irq name.