Re: [RFC][PATCH 3/4] power: reset: Add sram-reboot-mode driver

[John Stultz]

On Wed, Aug 3, 2016 at 6:03 PM, Bjorn Andersson
<bjorn.andersson@xxxxxxxxxx> wrote:
> On Wed 03 Aug 16:05 PDT 2016, John Stultz wrote:
>
> [..]
>> diff --git a/drivers/power/reset/sram-reboot-mode.c b/drivers/power/reset/sram-reboot-mode.c
> [..]
>> +
>> +struct sram_reboot_mode {
>> +     struct reboot_mode_driver reboot;
>> +     void __iomem *reboot_reason_val_addr;
>
> 23 characters is...a lot of characters...

Fair enough. Renamed to reason_addr.


>> +     res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>> +     if (!res)
>> +             return PTR_ERR(res);
>> +
>> +     sram_rbm->reboot_reason_val_addr = devm_ioremap(&pdev->dev, res->start,
>> +                                                      resource_size(res));
>
> Use devm_ioremap_resource() instead, it saves you the return value check
> on platform_get_resource() and is cleaner.

Ok. Done.


>> +     if (IS_ERR(sram_rbm->reboot_reason_val_addr))
>> +             return PTR_ERR(sram_rbm->reboot_reason_val_addr);
>> +
>> +     ret = reboot_mode_register(&sram_rbm->reboot);
>
> I think you should take the time to throw in a
> devm_reboot_mode_register(), it would save you from the
> dev_set_drvdata() and you can drop the remove function.

So I've only got a vague sense of what your suggesting here. Do you
have a pointer to a good example?

thanks
-john