Re: [PATCH 08/11] net/fsl: use of_property_read_bool

[Julia Lawall]

On Fri, 5 Aug 2016, Johannes Berg wrote:

> On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
> >Â
> > Can I do the same for:
> >
> > ÂÂÂÂÂÂÂÂif (of_property_read_bool(np, "phy-clk-valid"))
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pdata->check_phy_clk_valid = 1;
> > ÂÂÂÂÂÂÂÂelse
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pdata->check_phy_clk_valid = 0;
> >
> > The type is not bool, but:
> >
> > include/linux/fsl_devices.h:ÂÂÂ unsignedÂÂÂÂÂÂÂ check_phy_clk_valid:1;
> >
> The type doesn't even matter, does it? Any bool->int conversion should
> result in 0/1.

Just paranoid.  Thanks.

julia