Re: [PATCH 08/11] net/fsl: use of_property_read_bool

From: Johannes Berg
Date: Fri Aug 05 2016 - 06:31:20 EST


On Fri, 2016-08-05 at 12:08 +0200, Julia Lawall wrote:
>Â
> Can I do the same for:
>
> ÂÂÂÂÂÂÂÂif (of_property_read_bool(np, "phy-clk-valid"))
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pdata->check_phy_clk_valid = 1;
> ÂÂÂÂÂÂÂÂelse
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ pdata->check_phy_clk_valid = 0;
>
> The type is not bool, but:
>
> include/linux/fsl_devices.h:ÂÂÂ unsignedÂÂÂÂÂÂÂ check_phy_clk_valid:1;
>
The type doesn't even matter, does it? Any bool->int conversion should
result in 0/1.

johannes