Re: [PATCH] perf tools mem: Fix -t store option for record command

[Arnaldo Carvalho de Melo]

Em Thu, Aug 11, 2016 at 02:00:32PM +0200, Jiri Olsa escreveu:
> On Thu, Aug 11, 2016 at 08:51:38AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu:
> > > Michael reported 'perf mem -t store record' being broken.
> > > The reason is latest rework of this area:
> > >   commit acbe613e0c03 ("perf tools: Add monitored events array")
> > > 
> > > We don't mark perf_mem_events store record when -t store
> > > option is specified.
> > > 
> > > Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
> >          ^^^^^^
> > I'll remove this extraneous bit
> 
> well, checkpatch script complained about that when
> I did not put it there..  but I don't mind ;-)

Huh?

[acme@jouet linux]$ grep Fixes /wb/1.patch 
Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
[acme@jouet linux]$ scripts/checkpatch.pl /wb/1.patch 
total: 0 errors, 0 warnings, 9 lines checked

/wb/1.patch has no obvious style problems and is ready for submission.
[acme@jouet linux]$ vim /wb/1.patch 
[acme@jouet linux]$ grep Fixes /wb/1.patch 
Fixes: acbe613e0c03 ("perf tools: Add monitored events array")
[acme@jouet linux]$ scripts/checkpatch.pl /wb/1.patch 
total: 0 errors, 0 warnings, 9 lines checked

/wb/1.patch has no obvious style problems and is ready for submission.
[acme@jouet linux]$ 

- Arnaldo