Re: [PATCH] perf tools mem: Fix -t store option for record command

[Jiri Olsa]

On Thu, Aug 11, 2016 at 11:46:46AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 11, 2016 at 02:00:32PM +0200, Jiri Olsa escreveu:
> > On Thu, Aug 11, 2016 at 08:51:38AM -0300, Arnaldo Carvalho de Melo wrote:
> > > Em Thu, Aug 11, 2016 at 10:50:57AM +0200, Jiri Olsa escreveu:
> > > > Michael reported 'perf mem -t store record' being broken.
> > > > The reason is latest rework of this area:
> > > >   commit acbe613e0c03 ("perf tools: Add monitored events array")
> > > > 
> > > > We don't mark perf_mem_events store record when -t store
> > > > option is specified.
> > > > 
> > > > Fixes: commit acbe613e0c03 ("perf tools: Add monitored events array")
> > >          ^^^^^^
> > > I'll remove this extraneous bit
> > 
> > well, checkpatch script complained about that when
> > I did not put it there..  but I don't mind ;-)
> 
> Huh?

ah that was the other line with the commit number,
the one with Fixes: tag is ok.. nevermind, sry for noise ;-)

jirka


---
[jolsa@krava linux-perf]$ ./scripts/checkpatch.pl 0001-perf-tools-mem-Fix-t-store-option-for-record-command.patch 
ERROR: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit acbe613e0c03 ("perf tools: Add monitored events array")'
#8: 
  acbe613e0c03 ("perf tools: Add monitored events array")

total: 1 errors, 0 warnings, 9 lines checked