Re: [PATCH] proc, smaps: reduce printing overhead

From: Joe Perches
Date: Thu Aug 18 2016 - 10:46:16 EST


On Thu, 2016-08-18 at 16:41 +0200, Michal Hocko wrote:
> On Thu 18-08-16 16:26:16, Michal Hocko wrote:
> > b) doesn't it try to be overly clever when doing that in the caller
> > doesn't cost all that much? Sure you can save few bytes in the spaces
> > but then I would just argue to use \t rather than fixed string length.
> ohh, I misread the code. It tries to emulate the width formater. But is
> this really necessary? Do we know about any tools doing a fixed string
> parsing?

I don't, but it's proc and all the output formatting
shouldn't be changed.

Appended to is generally OK, but whitespace changed is
not good.