Re: [PATCH 1/7] ARM: dts: exynos: Add missing memory node for Exynos5440 boards

[Javier Martinez Canillas]

Hello Bartlomiej,

On 08/31/2016 07:22 PM, Bartlomiej Zolnierkiewicz wrote:
> 
> Hi,
> 
> On Wednesday, August 31, 2016 02:14:33 PM Javier Martinez Canillas wrote:
>> The skeleton.dtsi file was removed in ARM64 for different reasons as
>> explained in commit ("3ebee5a2e141 arm64: dts: kill skeleton.dtsi").
>>
>> These also applies to ARM and it will also allow to get rid of the
>> following DTC warnings in the future:
>>
>> "Node /memory has a reg or ranges property, but no unit name"
>>
>> But these boards don't have a memory node defined, so removing the
>> skeleton.dtsi inclusion in exynos4.dtsi will cause a change in the
>> compiled DTB. Add a dummy memory node so the compiled DTB doesn't
>> change if the skeleton.dtsi is removed from exynos4.dtsi.
>>
>> Eventually the correct starting addresses and sizes should be used
>> but I didn't find that information.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
>> ---
>>
>>  arch/arm/boot/dts/exynos5440-sd5v1.dts    | 5 +++++
>>  arch/arm/boot/dts/exynos5440-ssdk5440.dts | 5 +++++
>>  2 files changed, 10 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5440-sd5v1.dts b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> index a98501bab6fc..333db4ff373a 100644
>> --- a/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> +++ b/arch/arm/boot/dts/exynos5440-sd5v1.dts
>> @@ -20,6 +20,11 @@
>>  		bootargs = "root=/dev/sda2 rw rootwait ignore_loglevel earlyprintk no_console_suspend mem=2048M@0x80000000 mem=6144M@0x100000000 console=ttySAC0,115200";
>>  	};
>>  
>> +	memory {
>> +		device_type = "memory";
>> +		reg = <0 0>;
>> +	};
> 
> I think that this node deserves a FIXME comment.
> 

Agreed. I'll add one in v2 for both nodes.

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America