Re: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

[Kuninori Morimoto]

Hi

> Khiem Nguyen (5):
>  thermal: rcar_gen3_thermal: Document the R-Car Gen3 thermal bindings
>  thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver support
>  arm64: dts: r8a7795: Add R-Car Gen3 thermal support
>  arm64: dts: r8a7796: Add R-Car Gen3 thermal support
>  arm64: defconfig: Enable R-Car Gen3 thermal support

For all patches

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

> +static int rcar_gen3_thermal_get_temp(void *devdata, int *temp)
> +{
> +	struct rcar_gen3_thermal_priv *priv = devdata;
> +	int ctemp;
> +	unsigned long flags;
> +
> +	rcar_gen3_thermal_update_temp(priv);
> +
> +	spin_lock_irqsave(&priv->lock, flags);
> +	ctemp = _linear_temp_converter(priv->coef, priv->ctemp);
> +	spin_unlock_irqrestore(&priv->lock, flags);

This is not a big deal, but, as I mentioned in v1 patch,
having pointer for _linear_temp_converter() parameter is good idea.
	_linear_temp_converter(&priv->coef, xxx);

or
	_linear_temp_converter(priv);