Re: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

[Geert Uytterhoeven]

Hi Khiem

On Sat, Sep 3, 2016 at 7:25 AM, Khiem Nguyen
<khiem.nguyen.xt@xxxxxxxxxxx> wrote:
> --- /dev/null
> +++ b/drivers/thermal/rcar_gen3_thermal.c

> +static int rcar_gen3_thermal_probe(struct platform_device *pdev)
> +{

> +       priv->id = of_alias_get_id(dev->of_node, "tsc");
> +       if (priv->id < 0) {
> +               dev_err(dev, "Failed to get alias id (%d)\n", priv->id);
> +               ret = priv->id;
> +               goto error_unregister;
> +       }

In v1, Morimoto-san wondered whether the alias is really needed, but you
haven't addressed his question.

While aliases can be useful in DT source files, using aliases like this imposes
hardcoded instance numbers, which is something we try to avoid these days.
Also, this puts a hard requirement on the presence of the alias in DT, which
should be documented in the DT bindings.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds