RE: [PATCH 2/5 v2] thermal: rcar_gen3_thermal: Add R-Car Gen3 thermal driver

[Khiem Nguyen]

Hi Geert,

Thanks for your comment.

> > +static int rcar_gen3_thermal_probe(struct platform_device *pdev) {
> 
> > +       priv->id = of_alias_get_id(dev->of_node, "tsc");
> > +       if (priv->id < 0) {
> > +               dev_err(dev, "Failed to get alias id (%d)\n", priv->id);
> > +               ret = priv->id;
> > +               goto error_unregister;
> > +       }
> 
> In v1, Morimoto-san wondered whether the alias is really needed, but you haven't
> addressed his question.
> 
> While aliases can be useful in DT source files, using aliases like this imposes
> hardcoded instance numbers, which is something we try to avoid these days.
> Also, this puts a hard requirement on the presence of the alias in DT, which should
> be documented in the DT bindings.

OK.
I prefer updating DT binding to describe alias.

There is requirement about coefficient to calculate temperature,
and the coefficient value (fixed value) is different among thermal sensors.

Thanks.

Best regards,
KHIEM Nguyen