Re: [PATCH v2 25/33] include/linux/resctrl.h: Define fork and exit functions in a new header file

From: Thomas Gleixner
Date: Thu Sep 08 2016 - 12:10:44 EST


On Thu, 8 Sep 2016, Fenghua Yu wrote:

> From: Fenghua Yu <fenghua.yu@xxxxxxxxx>
>
> A new header file is created in include/linux/resctrl.h. It contains

No comment. You should be able to guess what I'm trying not to say.

> defintions of rdtgroup_fork and rdtgroup_exit for x86. The functions
> are empty for other architectures.
>
> Signed-off-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>
> Reviewed-by: Tony Luck <tony.luck@xxxxxxxxx>
> ---
> include/linux/resctrl.h | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
> create mode 100644 include/linux/resctrl.h
>
> diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
> new file mode 100644
> index 0000000..68dabc4
> --- /dev/null
> +++ b/include/linux/resctrl.h
> @@ -0,0 +1,12 @@
> +#ifndef _LINUX_RESCTRL_H
> +#define _LINUX_RESCTRL_H
> +
> +#ifdef CONFIG_INTEL_RDT
> +extern void rdtgroup_fork(struct task_struct *child);
> +extern void rdtgroup_exit(struct task_struct *tsk);
> +#else
> +static inline void rdtgroup_fork(struct task_struct *child) {}
> +static inline void rdtgroup_exit(struct task_struct *tsk) {}
> +#endif /* CONFIG_X86 */
> +
> +#endif /* _LINUX_RESCTRL_H */
> --
> 2.5.0
>
>