Re: [PATCH 3/5] nbd: use flags instead of bool

From: Joe Perches
Date: Fri Sep 09 2016 - 12:15:13 EST


On Fri, 2016-09-09 at 10:11 -0600, Jens Axboe wrote:
> The variable is called 'runtime_flags' - if that doesn't already tell
> the reader how it's used, then I'd suggest the reader go read something
> else.
>
> I'm all for using established APIs where it makes sense. Declaring a
> bitmap for a few fields isn't that.

Deviating from established APIs makes no sense.