Re: [PATCH 3/5] nbd: use flags instead of bool

[Jens Axboe]

On 09/09/2016 10:15 AM, Joe Perches wrote:
> On Fri, 2016-09-09 at 10:11 -0600, Jens Axboe wrote:
> > The variable is called 'runtime_flags' - if that doesn't already tell
> > the reader how it's used, then I'd suggest the reader go read something
> > else.
> >
> > I'm all for using established APIs where it makes sense. Declaring a
> > bitmap for a few fields isn't that.
>
> Deviating from established APIs makes no sense.

Look, doing set/test/clear bit on an unsigned long is a very well
established API. We've been doing that _forever_. As I said in my
original email, I have nothing against using bitmaps _where they make
sense_. Manually allocating an array for X number of bits (where X >
32), yes, by all means use the bitmap helpers.

This is my final reply on this topic.

--
Jens Axboe