Re: [PATCH 6/7] perf ui/tui: Reset output width for hierarchy

From: Namhyung Kim
Date: Mon Sep 12 2016 - 21:01:29 EST


On Mon, Sep 12, 2016 at 11:27:47AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Mon, Sep 12, 2016 at 03:19:57PM +0900, Namhyung Kim escreveu:
> > When --hierarchy option is used, each entry has its own hpp_list to show
> > the result. But it missed to update width of each column.
>
> Ditto, missing "Fixes:" tag.

It's the same commit. Will add the tag.

Thanks,
Namhyung


>
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> > ---
> > tools/perf/ui/browsers/hists.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
> > index 35e44b1879e3..49db16334814 100644
> > --- a/tools/perf/ui/browsers/hists.c
> > +++ b/tools/perf/ui/browsers/hists.c
> > @@ -2067,6 +2067,7 @@ void hist_browser__init(struct hist_browser *browser,
> > struct hists *hists)
> > {
> > struct perf_hpp_fmt *fmt;
> > + struct perf_hpp_list_node *node;
> >
> > browser->hists = hists;
> > browser->b.refresh = hist_browser__refresh;
> > @@ -2079,6 +2080,11 @@ void hist_browser__init(struct hist_browser *browser,
> > perf_hpp__reset_width(fmt, hists);
> > ++browser->b.columns;
> > }
> > + /* hierarchy entries have their own hpp list */
> > + list_for_each_entry(node, &hists->hpp_formats, list) {
> > + perf_hpp_list__for_each_format(&node->hpp, fmt)
> > + perf_hpp__reset_width(fmt, hists);
> > + }
> > }
> >
> > struct hist_browser *hist_browser__new(struct hists *hists)
> > --
> > 2.9.3