Re: [PATCH] pinctrl: ret needs to be an int for -ve return value from regmap_update_bits

[Linus Walleij]

On Sun, Sep 11, 2016 at 10:36 AM, Colin King <colin.king@xxxxxxxxxxxxx> wrote:

> From: Colin Ian King <colin.king@xxxxxxxxxxxxx>
>
> Macro regmap_update_bits can return a -ve on an error value so ret
> needs to be an integer rather than a bool type.
>
> Fixes warning found by static analysis with cppcheck:
> [drivers/pinctrl/aspeed/pinctrl-aspeed.c:192]: (warning) Comparison of
>   a boolean expression with an integer other than 0 or 1.
>
> Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx>

Dropping this but added your Reported-by to Arnds patch.

Yours,
Linus Walleij