RE: [PATCH 3/3] Drivers: hv: utils: Support TimeSync version 4.0 protocol samples.

[Alex Ng (LIS)]

> On Thu, Sep 08, kys@xxxxxxxxxxxxxxxxxxxxxx wrote:
> 
> > -	default:
> > +	case(VERSION_WIN10):
> >  		util_fw_version = UTIL_FW_VERSION;
> >  		sd_srv_version = SD_VERSION;
> >  		ts_srv_version = TS_VERSION;
> >  		hb_srv_version = HB_VERSION;
> > +		break;
> > +	default:
> > +		util_fw_version = UTIL_FW_VERSION;
> > +		sd_srv_version = SD_VERSION;
> > +		ts_srv_version = TS_VERSION_3;
> > +		hb_srv_version = HB_VERSION;
> 
> Is this correct? An old kernel on a newer host would use the old protocol. I
> assume that new host will also know about the old protocol?

This is correct. An old kernel uses the old protocol even with the new host.
New hosts understand the old protocol.

> Perhaps a better approach would be to list the known existing hosts and use
> the new protocol for upcoming, unknown hosts via 'default:'.

This is a good idea. I will create another patch that addresses this.

> 
> Olaf