Re: [PATCH] driver-core: platform: Catch errors from calls to irq_get_irq_data

From: Linus Walleij
Date: Wed Sep 14 2016 - 07:12:16 EST


On Wed, Sep 14, 2016 at 11:44 AM, Greg Kroah-Hartman
<gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> On Wed, Sep 14, 2016 at 11:06:08AM +0200, Linus Walleij wrote:
>> On Wed, Sep 14, 2016 at 5:32 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>>
>> > irq_get_irq_data() can return NULL, which results in a nasty crash.
>> > Check its return value before passing it on to irqd_set_trigger_type().
>> >
>> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
>>
>> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
>>
>> Should probably be tagged for stable.
>
> Why, are there any systems that are currently broken without this change
> right now?

I guess GÃnther can tell if there are any, but I guess you're right,
no need to rush it for stable then.

Yours,
Linus Walleij