Re: [PATCH] driver-core: platform: Catch errors from calls to irq_get_irq_data

From: Guenter Roeck
Date: Wed Sep 14 2016 - 10:29:31 EST


On 09/14/2016 02:44 AM, Greg Kroah-Hartman wrote:
On Wed, Sep 14, 2016 at 11:06:08AM +0200, Linus Walleij wrote:
On Wed, Sep 14, 2016 at 5:32 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

irq_get_irq_data() can return NULL, which results in a nasty crash.
Check its return value before passing it on to irqd_set_trigger_type().

Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Should probably be tagged for stable.

Why, are there any systems that are currently broken without this change
right now?

I only see it in -next, and that is due to a patch there.

Guenter