Re: [PATCH 05/15] hisi_sas: use safe BITS_PER_BYTE for slot tag size calculation

[Hannes Reinecke]

On 09/06/2016 05:36 PM, John Garry wrote:
> The memory calculation for the tags bitmap should use BITS_PER_BYTE
> macro instead of coincidental same value of sizeof(unsigned long).
> 
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> ---
>  drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_main.c b/drivers/scsi/hisi_sas/hisi_sas_main.c
> index 0e48751..dcb17a3 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_main.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_main.c
> @@ -1309,7 +1309,7 @@ static int hisi_sas_alloc(struct hisi_hba *hisi_hba, struct Scsi_Host *shost)
>  	memset(hisi_hba->breakpoint, 0, s);
>  
>  	hisi_hba->slot_index_count = max_command_entries;
> -	s = hisi_hba->slot_index_count / sizeof(unsigned long);
> +	s = hisi_hba->slot_index_count / BITS_PER_BYTE;
>  	hisi_hba->slot_index_tags = devm_kzalloc(dev, s, GFP_KERNEL);
>  	if (!hisi_hba->slot_index_tags)
>  		goto err_out;
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@xxxxxxx			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)