Re: [PATCH 06/15] hisi_sas: disable dlvry queues once at reset for v2 hw

[Hannes Reinecke]

On 09/06/2016 05:36 PM, John Garry wrote:
> The Delivery queue enable register should only be written
> to once at reset for v2 hw.
> 
> Signed-off-by: John Garry <john.garry@xxxxxxxxxx>
> ---
>  drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> index 25e7c58..aca2b80 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v2_hw.c
> @@ -685,9 +685,7 @@ static int reset_hw_v2_hw(struct hisi_hba *hisi_hba)
>  	else
>  		reset_val = 0x7ffff;
>  
> -	/* Disable all of the DQ */
> -	for (i = 0; i < HISI_SAS_MAX_QUEUES; i++)
> -		hisi_sas_write32(hisi_hba, DLVRY_QUEUE_ENABLE, 0);
> +	hisi_sas_write32(hisi_hba, DLVRY_QUEUE_ENABLE, 0);
>  
>  	/* Disable all of the PHYs */
>  	for (i = 0; i < hisi_hba->n_phy; i++) {
> 
Reviewed-by: Hannes Reinecke <hare@xxxxxxxx>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@xxxxxxx			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)