Re: [PATCH] usb: phy: add USB_SUPPORT dependency
From: Arnd Bergmann
Date: Wed Sep 14 2016 - 09:52:05 EST
On Thursday, September 8, 2016 7:07:32 PM CEST Kishon Vijay Abraham I wrote:
> On Wednesday 07 September 2016 03:01 PM, Hans de Goede wrote:
> > Hi,
> > On 06-09-16 14:54, Arnd Bergmann wrote:
> >> The driver now calls of_usb_get_dr_mode_by_phy, which is part of the
> >> USB core layer, and it fails to build when that is not provided:
> >> drivers/phy/phy-sun4i-usb.o: In function `sun4i_usb_phy_probe':
> >> phy-sun4i-usb.c:(.text.sun4i_usb_phy_probe+0x140): undefined reference to
> >> `of_usb_get_dr_mode_by_phy'
> >> We already have a couple of other PHY drivers with a dependency
> >> on USB_SUPPORT, so that seems to be the easiest fix here.
> >> An alternative would be to adjust the #ifdef in include/linux/usb/of.h
> >> to also check for CONFIG_USB_SUPPORT.
> >> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> >> Fixes: b33ecca87df9 ("phy-sun4i-usb: Add support for peripheral-only mode")
> > Good catch, patch LGTM:
> > Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> merged, thanks.
There is one more that came up today, with the meson usb2 phy driver.
I've now implemented the "alternative" I mentioned above, which should
avoid introducing other instances of this bug in the future.
Sorry for all the back-and-forth here,