Re: [PATCH v2 3/5] drm/bridge: squash lines for simple wrapper functions

From: Sean Paul
Date: Thu Sep 15 2016 - 10:47:09 EST


On Thu, Sep 15, 2016 at 9:51 AM, Sean Paul <seanpaul@xxxxxxxxxxxx> wrote:
> On Wed, Sep 14, 2016 at 10:39 AM, Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
>> Remove unneeded variables and assignments.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
>
> Reviewed-by: Sean Paul <seanpaul@xxxxxxxxxxxx>
>

Decided to apply patches 1-4 to drm-misc

Thanks,

Sean

>> ---
>>
>> drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 20 ++++----------------
>> 1 file changed, 4 insertions(+), 16 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> index 52c1b6b..fae0293 100644
>> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c
>> @@ -1073,34 +1073,22 @@ void analogix_dp_set_lane3_link_training(struct analogix_dp_device *dp,
>>
>> u32 analogix_dp_get_lane0_link_training(struct analogix_dp_device *dp)
>> {
>> - u32 reg;
>> -
>> - reg = readl(dp->reg_base + ANALOGIX_DP_LN0_LINK_TRAINING_CTL);
>> - return reg;
>> + return readl(dp->reg_base + ANALOGIX_DP_LN0_LINK_TRAINING_CTL);
>> }
>>
>> u32 analogix_dp_get_lane1_link_training(struct analogix_dp_device *dp)
>> {
>> - u32 reg;
>> -
>> - reg = readl(dp->reg_base + ANALOGIX_DP_LN1_LINK_TRAINING_CTL);
>> - return reg;
>> + return readl(dp->reg_base + ANALOGIX_DP_LN1_LINK_TRAINING_CTL);
>> }
>>
>> u32 analogix_dp_get_lane2_link_training(struct analogix_dp_device *dp)
>> {
>> - u32 reg;
>> -
>> - reg = readl(dp->reg_base + ANALOGIX_DP_LN2_LINK_TRAINING_CTL);
>> - return reg;
>> + return readl(dp->reg_base + ANALOGIX_DP_LN2_LINK_TRAINING_CTL);
>> }
>>
>> u32 analogix_dp_get_lane3_link_training(struct analogix_dp_device *dp)
>> {
>> - u32 reg;
>> -
>> - reg = readl(dp->reg_base + ANALOGIX_DP_LN3_LINK_TRAINING_CTL);
>> - return reg;
>> + return readl(dp->reg_base + ANALOGIX_DP_LN3_LINK_TRAINING_CTL);
>> }
>>
>> void analogix_dp_reset_macro(struct analogix_dp_device *dp)
>> --
>> 1.9.1
>>